]> bbs.cooldavid.org Git - net-next-2.6.git/commitdiff
caif: tty's are kref objects so take a reference
authorAlan Cox <alan@linux.intel.com>
Wed, 7 Apr 2010 23:50:00 +0000 (16:50 -0700)
committerDavid S. Miller <davem@davemloft.net>
Wed, 7 Apr 2010 23:50:00 +0000 (16:50 -0700)
I don't think this can be abused in this case but do things properly.

Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/caif/caif_serial.c

index c669ec37483bf612107b57134b9df2deca7c719b..38c0186cfbc290854609f19a11b19112811d3879 100644 (file)
@@ -319,7 +319,7 @@ static int ldisc_open(struct tty_struct *tty)
        sprintf(name, "cf%s", tty->name);
        dev = alloc_netdev(sizeof(*ser), name, caifdev_setup);
        ser = netdev_priv(dev);
-       ser->tty = tty;
+       ser->tty = tty_kref_get(tty);
        ser->dev = dev;
        debugfs_init(ser, tty);
        tty->receive_room = N_TTY_BUF_SIZE;
@@ -352,6 +352,7 @@ static void ldisc_close(struct tty_struct *tty)
        unregister_netdevice(ser->dev);
        list_del(&ser->node);
        debugfs_deinit(ser);
+       tty_kref_put(ser->tty);
        if (!islocked)
                rtnl_unlock();
 }