]> bbs.cooldavid.org Git - net-next-2.6.git/commitdiff
caif: check write operations
authorAlan Cox <alan@linux.intel.com>
Wed, 7 Apr 2010 23:49:31 +0000 (16:49 -0700)
committerDavid S. Miller <davem@davemloft.net>
Wed, 7 Apr 2010 23:49:31 +0000 (16:49 -0700)
write is optional for a tty device. Check that we have a write op rather
than calling NULL.

Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/caif/caif_serial.c

index 3502f607117fcd2a8eb26ba34b46379fea5b4fb6..c669ec37483bf612107b57134b9df2deca7c719b 100644 (file)
@@ -312,6 +312,10 @@ static int ldisc_open(struct tty_struct *tty)
        char name[64];
        int result;
 
+       /* No write no play */
+       if (tty->ops->write == NULL)
+               return -EOPNOTSUPP;
+
        sprintf(name, "cf%s", tty->name);
        dev = alloc_netdev(sizeof(*ser), name, caifdev_setup);
        ser = netdev_priv(dev);