]> bbs.cooldavid.org Git - net-next-2.6.git/commitdiff
Merge remote branch 'airlied/drm-core-next' into tmp
authorChris Wilson <chris@chris-wilson.co.uk>
Tue, 19 Oct 2010 08:13:00 +0000 (09:13 +0100)
committerChris Wilson <chris@chris-wilson.co.uk>
Tue, 19 Oct 2010 08:14:50 +0000 (09:14 +0100)
1  2 
drivers/gpu/drm/i915/i915_dma.c
drivers/gpu/drm/i915/intel_display.c
drivers/gpu/drm/i915/intel_fb.c

index f451af69d4377bb238300e11075b0033a448405d,251987307ebebe4926dbc9224671f2df68137f16..a99fae33bdf6bd8fe7fe39ccf7f9b070fa11b43c
@@@ -1244,8 -1244,6 +1244,8 @@@ static int i915_load_modeset_init(struc
        if (ret)
                goto cleanup_ringbuffer;
  
 +      intel_register_dsm_handler();
 +
        ret = vga_switcheroo_register_client(dev->pdev,
                                             i915_switcheroo_set_state,
                                             i915_switcheroo_can_switch);
@@@ -2065,6 -2063,9 +2065,9 @@@ int i915_driver_load(struct drm_device 
        dev_priv->mchdev_lock = &mchdev_lock;
        spin_unlock(&mchdev_lock);
  
+       /* XXX Prevent module unload due to memory corruption bugs. */
+       __module_get(THIS_MODULE);
        return 0;
  
  out_workqueue_free:
@@@ -2152,9 -2153,6 +2155,9 @@@ int i915_driver_unload(struct drm_devic
                drm_mm_takedown(&dev_priv->mm.vram);
  
                intel_cleanup_overlay(dev);
 +
 +              if (!I915_NEED_GFX_HWS(dev))
 +                      i915_free_hws(dev);
        }
  
        intel_teardown_gmbus(dev);
index 8e98d708f97059dd07f871c3b4de384a558e44d5,96d08a9f3aaaa8e9b8351ccad80f882fabc6e614..faacbbdbb270ac81729fed72d3c8f0be8ccf3286
@@@ -932,6 -932,10 +932,6 @@@ intel_find_pll_ironlake_dp(const intel_
        struct drm_device *dev = crtc->dev;
        intel_clock_t clock;
  
 -      /* return directly when it is eDP */
 -      if (HAS_eDP)
 -              return true;
 -
        if (target < 200000) {
                clock.n = 1;
                clock.p1 = 2;
@@@ -1488,7 -1492,7 +1488,7 @@@ err_unpin
  /* Assume fb object is pinned & idle & fenced and just update base pointers */
  static int
  intel_pipe_set_base_atomic(struct drm_crtc *crtc, struct drm_framebuffer *fb,
-                          int x, int y, int enter)
+                          int x, int y, enum mode_set_atomic state)
  {
        struct drm_device *dev = crtc->dev;
        struct drm_i915_private *dev_priv = dev->dev_private;
@@@ -1610,7 -1614,8 +1610,8 @@@ intel_pipe_set_base(struct drm_crtc *cr
                           atomic_read(&obj_priv->pending_flip) == 0);
        }
  
-       ret = intel_pipe_set_base_atomic(crtc, crtc->fb, x, y, 0);
+       ret = intel_pipe_set_base_atomic(crtc, crtc->fb, x, y,
+                                        LEAVE_ATOMIC_MODE_SET);
        if (ret) {
                i915_gem_object_unpin(to_intel_framebuffer(crtc->fb)->obj);
                mutex_unlock(&dev->struct_mutex);
@@@ -1714,9 -1719,6 +1715,9 @@@ static void ironlake_fdi_link_train(str
        POSTING_READ(reg);
        udelay(150);
  
 +      /* Ironlake workaround, enable clock pointer after FDI enable*/
 +      I915_WRITE(FDI_RX_CHICKEN(pipe), FDI_RX_PHASE_SYNC_POINTER_ENABLE);
 +
        reg = FDI_RX_IIR(pipe);
        for (tries = 0; tries < 5; tries++) {
                temp = I915_READ(reg);
                DRM_ERROR("FDI train 2 fail!\n");
  
        DRM_DEBUG_KMS("FDI train done\n");
 +
 +      /* enable normal train */
 +      reg = FDI_TX_CTL(pipe);
 +      temp = I915_READ(reg);
 +      temp &= ~FDI_LINK_TRAIN_NONE;
 +      temp |= FDI_LINK_TRAIN_NONE | FDI_TX_ENHANCE_FRAME_ENABLE;
 +      I915_WRITE(reg, temp);
 +
 +      reg = FDI_RX_CTL(pipe);
 +      temp = I915_READ(reg);
 +      if (HAS_PCH_CPT(dev)) {
 +              temp &= ~FDI_LINK_TRAIN_PATTERN_MASK_CPT;
 +              temp |= FDI_LINK_TRAIN_NORMAL_CPT;
 +      } else {
 +              temp &= ~FDI_LINK_TRAIN_NONE;
 +              temp |= FDI_LINK_TRAIN_NONE;
 +      }
 +      I915_WRITE(reg, temp | FDI_RX_ENHANCE_FRAME_ENABLE);
 +
 +      /* wait one idle pattern time */
 +      POSTING_READ(reg);
 +      udelay(1000);
  }
  
  static const int const snb_b_fdi_train_param [] = {
@@@ -2022,7 -2002,8 +2023,7 @@@ static void ironlake_crtc_enable(struc
  
        /* Enable panel fitting for LVDS */
        if (dev_priv->pch_pf_size &&
 -          (intel_pipe_has_type(crtc, INTEL_OUTPUT_LVDS)
 -           || HAS_eDP || intel_pch_has_edp(crtc))) {
 +          (intel_pipe_has_type(crtc, INTEL_OUTPUT_LVDS) || HAS_eDP)) {
                /* Force use of hard-coded filter coefficients
                 * as some pre-programmed values are broken,
                 * e.g. x201.
        if ((temp & PIPECONF_ENABLE) == 0) {
                I915_WRITE(reg, temp | PIPECONF_ENABLE);
                POSTING_READ(reg);
 -              udelay(100);
 +              intel_wait_for_vblank(dev, intel_crtc->pipe);
        }
  
        /* configure and enable CPU plane */
        I915_WRITE(TRANS_VBLANK(pipe), I915_READ(VBLANK(pipe)));
        I915_WRITE(TRANS_VSYNC(pipe),  I915_READ(VSYNC(pipe)));
  
 -      /* enable normal train */
 -      reg = FDI_TX_CTL(pipe);
 -      temp = I915_READ(reg);
 -      temp &= ~FDI_LINK_TRAIN_NONE;
 -      temp |= FDI_LINK_TRAIN_NONE | FDI_TX_ENHANCE_FRAME_ENABLE;
 -      I915_WRITE(reg, temp);
 -
 -      reg = FDI_RX_CTL(pipe);
 -      temp = I915_READ(reg);
 -      if (HAS_PCH_CPT(dev)) {
 -              temp &= ~FDI_LINK_TRAIN_PATTERN_MASK_CPT;
 -              temp |= FDI_LINK_TRAIN_NORMAL_CPT;
 -      } else {
 -              temp &= ~FDI_LINK_TRAIN_NONE;
 -              temp |= FDI_LINK_TRAIN_NONE;
 -      }
 -      I915_WRITE(reg, temp | FDI_RX_ENHANCE_FRAME_ENABLE);
 -
 -      /* wait one idle pattern time */
 -      POSTING_READ(reg);
 -      udelay(100);
 -
        /* For PCH DP, enable TRANS_DP_CTL */
        if (HAS_PCH_CPT(dev) &&
            intel_pipe_has_type(crtc, INTEL_OUTPUT_DISPLAYPORT)) {
        temp |= I915_READ(PIPECONF(pipe)) & PIPE_BPC_MASK;
        I915_WRITE(reg, temp | TRANS_ENABLE);
        if (wait_for(I915_READ(reg) & TRANS_STATE_ENABLE, 100))
 -              DRM_ERROR("failed to enable transcoder\n");
 +              DRM_ERROR("failed to enable transcoder %d\n", pipe);
  
        intel_crtc_load_lut(crtc);
        intel_update_fbc(dev);
@@@ -2171,9 -2174,9 +2172,9 @@@ static void ironlake_crtc_disable(struc
        temp = I915_READ(reg);
        if (temp & PIPECONF_ENABLE) {
                I915_WRITE(reg, temp & ~PIPECONF_ENABLE);
 +              POSTING_READ(reg);
                /* wait for cpu pipe off, pipe state */
 -              if (wait_for((I915_READ(reg) & I965_PIPECONF_ACTIVE) == 0, 50))
 -                      DRM_ERROR("failed to turn off cpu pipe\n");
 +              intel_wait_for_pipe_off(dev, intel_crtc->pipe);
        }
  
        /* Disable PF */
        POSTING_READ(reg);
        udelay(100);
  
 +      /* Ironlake workaround, disable clock pointer after downing FDI */
 +      I915_WRITE(FDI_RX_CHICKEN(pipe),
 +                 I915_READ(FDI_RX_CHICKEN(pipe) &
 +                           ~FDI_RX_PHASE_SYNC_POINTER_ENABLE));
 +
        /* still set train pattern 1 */
        reg = FDI_TX_CTL(pipe);
        temp = I915_READ(reg);
@@@ -3625,8 -3623,7 +3626,8 @@@ static int intel_crtc_mode_set(struct d
                              refclk / 1000);
        } else if (!IS_GEN2(dev)) {
                refclk = 96000;
 -              if (HAS_PCH_SPLIT(dev))
 +              if (HAS_PCH_SPLIT(dev) &&
 +                  (!has_edp_encoder || intel_encoder_is_pch_edp(&has_edp_encoder->base)))
                        refclk = 120000; /* 120Mhz refclk */
        } else {
                refclk = 48000;
        /* FDI link */
        if (HAS_PCH_SPLIT(dev)) {
                int lane = 0, link_bw, bpp;
 -              /* eDP doesn't require FDI link, so just set DP M/N
 +              /* CPU eDP doesn't require FDI link, so just set DP M/N
                   according to current link config */
 -              if (has_edp_encoder) {
 +              if (has_edp_encoder && !intel_encoder_is_pch_edp(&encoder->base)) {
                        target_clock = mode->clock;
                        intel_edp_link_config(has_edp_encoder,
                                              &lane, &link_bw);
                } else {
 -                      /* DP over FDI requires target mode clock
 +                      /* [e]DP over FDI requires target mode clock
                           instead of link clock */
 -                      if (is_dp)
 +                      if (is_dp || intel_encoder_is_pch_edp(&has_edp_encoder->base))
                                target_clock = mode->clock;
                        else
                                target_clock = adjusted_mode->clock;
                                temp |= PIPE_8BPC;
                        else
                                temp |= PIPE_6BPC;
 -              } else if (has_edp_encoder || (is_dp && intel_pch_has_edp(crtc))) {
 +              } else if (has_edp_encoder) {
                        switch (dev_priv->edp.bpp/3) {
                        case 8:
                                temp |= PIPE_8BPC;
  
                                POSTING_READ(PCH_DREF_CONTROL);
                                udelay(200);
 +                      }
 +                      temp &= ~DREF_CPU_SOURCE_OUTPUT_MASK;
  
 -                              temp &= ~DREF_CPU_SOURCE_OUTPUT_MASK;
 -                              temp |= DREF_CPU_SOURCE_OUTPUT_DOWNSPREAD;
 +                      /* Enable CPU source on CPU attached eDP */
 +                      if (!intel_encoder_is_pch_edp(&has_edp_encoder->base)) {
 +                              if (dev_priv->lvds_use_ssc)
 +                                      temp |= DREF_CPU_SOURCE_OUTPUT_DOWNSPREAD;
 +                              else
 +                                      temp |= DREF_CPU_SOURCE_OUTPUT_NONSPREAD;
                        } else {
 -                              temp |= DREF_CPU_SOURCE_OUTPUT_NONSPREAD;
 +                              /* Enable SSC on PCH eDP if needed */
 +                              if (dev_priv->lvds_use_ssc) {
 +                                      DRM_ERROR("enabling SSC on PCH\n");
 +                                      temp |= DREF_SUPERSPREAD_SOURCE_ENABLE;
 +                              }
                        }
                        I915_WRITE(PCH_DREF_CONTROL, temp);
 +                      POSTING_READ(PCH_DREF_CONTROL);
 +                      udelay(200);
                }
        }
  
                        }
                        dpll |= DPLL_DVO_HIGH_SPEED;
                }
 -              if (is_dp)
 +              if (is_dp || intel_encoder_is_pch_edp(&has_edp_encoder->base))
                        dpll |= DPLL_DVO_HIGH_SPEED;
  
                /* compute bitmask from p1 value */
                dpll_reg = DPLL(pipe);
        }
  
 -      if (!has_edp_encoder) {
 +      /* PCH eDP needs FDI, but CPU eDP does not */
 +      if (!has_edp_encoder || intel_encoder_is_pch_edp(&has_edp_encoder->base)) {
                I915_WRITE(fp_reg, fp);
                I915_WRITE(dpll_reg, dpll & ~DPLL_VCO_ENABLE);
  
                }
        }
  
 -      if (is_dp)
 +      if (is_dp || intel_encoder_is_pch_edp(&has_edp_encoder->base)) {
                intel_dp_set_m_n(crtc, mode, adjusted_mode);
 -      else if (HAS_PCH_SPLIT(dev)) {
 +      else if (HAS_PCH_SPLIT(dev)) {
                /* For non-DP output, clear any trans DP clock recovery setting.*/
                if (pipe == 0) {
                        I915_WRITE(TRANSA_DATA_M1, 0);
                }
        }
  
 -      if (!has_edp_encoder) {
 +      if (!has_edp_encoder || intel_encoder_is_pch_edp(&has_edp_encoder->base)) {
                I915_WRITE(fp_reg, fp);
                I915_WRITE(dpll_reg, dpll);
  
                I915_WRITE(PIPE_LINK_M1(pipe), m_n.link_m);
                I915_WRITE(PIPE_LINK_N1(pipe), m_n.link_n);
  
 -              if (has_edp_encoder) {
 +              if (has_edp_encoder && !intel_encoder_is_pch_edp(&has_edp_encoder->base)) {
                        ironlake_set_pll_edp(crtc, adjusted_mode->clock);
 -              } else {
 -                      /* enable FDI RX PLL too */
 -                      reg = FDI_RX_CTL(pipe);
 -                      temp = I915_READ(reg);
 -                      I915_WRITE(reg, temp | FDI_RX_PLL_ENABLE);
 -
 -                      POSTING_READ(reg);
 -                      udelay(200);
 -
 -                      /* enable FDI TX PLL too */
 -                      reg = FDI_TX_CTL(pipe);
 -                      temp = I915_READ(reg);
 -                      I915_WRITE(reg, temp | FDI_TX_PLL_ENABLE);
 -
 -                      /* enable FDI RX PCDCLK */
 -                      reg = FDI_RX_CTL(pipe);
 -                      temp = I915_READ(reg);
 -                      I915_WRITE(reg, temp | FDI_PCDCLK);
 -
 -                      POSTING_READ(reg);
 -                      udelay(200);
                }
        }
  
@@@ -4990,9 -4995,8 +4991,9 @@@ static void do_intel_finish_page_flip(s
        obj_priv = to_intel_bo(work->pending_flip_obj);
  
        /* Initial scanout buffer will have a 0 pending flip count */
 -      if ((atomic_read(&obj_priv->pending_flip) == 0) ||
 -          atomic_dec_and_test(&obj_priv->pending_flip))
 +      atomic_clear_mask(1 << intel_crtc->plane,
 +                        &obj_priv->pending_flip.counter);
 +      if (atomic_read(&obj_priv->pending_flip) == 0)
                wake_up(&dev_priv->pending_flip_queue);
        schedule_work(&work->work);
  
@@@ -5089,7 -5093,7 +5090,7 @@@ static int intel_crtc_page_flip(struct 
                goto cleanup_objs;
  
        obj_priv = to_intel_bo(obj);
 -      atomic_inc(&obj_priv->pending_flip);
 +      atomic_add(1 << intel_crtc->plane, &obj_priv->pending_flip);
        work->pending_flip_obj = obj;
  
        if (IS_GEN3(dev) || IS_GEN2(dev)) {
@@@ -5745,13 -5749,6 +5746,13 @@@ void intel_init_clock_gating(struct drm
  
                I915_WRITE(PCH_DSPCLK_GATE_D, dspclk_gate);
  
 +              /*
 +               * On Ibex Peak and Cougar Point, we need to disable clock
 +               * gating for the panel power sequencer or it will fail to
 +               * start up when no ports are active.
 +               */
 +              I915_WRITE(SOUTH_DSPCLK_GATE_D, PCH_DPLSUNIT_CLOCK_GATE_DISABLE);
 +
                /*
                 * According to the spec the following bits should be set in
                 * order to enable memory self-refresh
@@@ -6134,9 -6131,6 +6135,9 @@@ void intel_modeset_cleanup(struct drm_d
        drm_kms_helper_poll_fini(dev);
        mutex_lock(&dev->struct_mutex);
  
 +      intel_unregister_dsm_handler();
 +
 +
        list_for_each_entry(crtc, &dev->mode_config.crtc_list, head) {
                /* Skip inactive CRTCs */
                if (!crtc->fb)
index b937ccfa7bec9a037ae7b6fddf6d635552a4aba1,521622b9be7a7fa9ddebdd79813c5530c1d06425..af2a1dddc28e2e908529db44a24cea44ff10d387
@@@ -225,8 -225,8 +225,8 @@@ static void intel_fbdev_destroy(struct 
  
        drm_framebuffer_cleanup(&ifb->base);
        if (ifb->obj) {
-               drm_gem_object_handle_unreference_unlocked(ifb->obj);
 -              drm_gem_object_unreference(ifb->obj);
 +              drm_gem_object_unreference_unlocked(ifb->obj);
+               ifb->obj = NULL;
        }
  }