]> bbs.cooldavid.org Git - net-next-2.6.git/commitdiff
USB: isp1362-hcd: Removes CONFIG_USB_OTG dependent code, fix build breakage
authorJavier Martinez Canillas <martinez.javier@gmail.com>
Thu, 9 Sep 2010 21:31:29 +0000 (17:31 -0400)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 22 Oct 2010 17:21:38 +0000 (10:21 -0700)
In today linux-next I got a compile error on usb/host/isp1362-hcd:

drivers/usb/host/isp1362-hcd.c: In function ‘isp1362_hub_control’:
drivers/usb/host/isp1362-hcd.c:1680: error: ‘ohci’ undeclared (first use in this function)

The problem is when the CONFIG_USB_OTG option is enabled.

ohci variable is never declared and there isn't any CONFIG_USB_OTG dependent code
besides the portion defined in isp1362_hub_control.

So I think that maybe USB OTG support is not needed/supported.

This patch removes the CONFIG_USB_OTG dependent block so the driver can compile cleanly.

Signed-off-by: Javier Martinez Canillas <martinez.javier@gmail.com>
Cc: Mike Frysinger <vapier@gentoo.org>
Cc: Lothar Wassmann <LW@KARO-electronics.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/usb/host/isp1362-hcd.c

index 0587ad4ce5c2948500dbd339b5d03f322b905fb6..ae304401938245c8d23dd3fe1250dcc47d55c668 100644 (file)
@@ -1676,13 +1676,6 @@ static int isp1362_hub_control(struct usb_hcd *hcd, u16 typeReq, u16 wValue,
                switch (wValue) {
                case USB_PORT_FEAT_SUSPEND:
                        _DBG(0, "USB_PORT_FEAT_SUSPEND\n");
-#ifdef CONFIG_USB_OTG
-                       if (ohci->hcd.self.otg_port == (wIndex + 1) &&
-                           ohci->hcd.self.b_hnp_enable) {
-                               start_hnp(ohci);
-                               break;
-                       }
-#endif
                        spin_lock_irqsave(&isp1362_hcd->lock, flags);
                        isp1362_write_reg32(isp1362_hcd, HCRHPORT1 + wIndex, RH_PS_PSS);
                        isp1362_hcd->rhport[wIndex] =