]> bbs.cooldavid.org Git - net-next-2.6.git/commitdiff
dc395x: decrease iteration for tag_number of max_command in start_scsi()
authorRoel Kluin <roel.kluin@gmail.com>
Wed, 11 Aug 2010 01:01:17 +0000 (18:01 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Wed, 11 Aug 2010 15:59:00 +0000 (08:59 -0700)
The tag_number reaches dcb->max_command + 1 after the loop, but when
the tag_number equals dcb->max_command an error message is already
issued. The last iteration therefore appears obsolete.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Cc: Oliver Neukum <oliver@neukum.name>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/scsi/dc395x.c

index bd977be7544e37355c35b2addf55d02ef9747039..54f50b07dac7f36fe5950efb9bdaf34340d4bbed 100644 (file)
@@ -1597,7 +1597,7 @@ static u8 start_scsi(struct AdapterCtlBlk* acb, struct DeviceCtlBlk* dcb,
                u32 tag_mask = 1;
                u8 tag_number = 0;
                while (tag_mask & dcb->tag_mask
-                      && tag_number <= dcb->max_command) {
+                      && tag_number < dcb->max_command) {
                        tag_mask = tag_mask << 1;
                        tag_number++;
                }