]> bbs.cooldavid.org Git - net-next-2.6.git/commitdiff
Staging: usbip: use print_hex_dump() instead of open coding it.
authorHimanshu Chauhan <himanshu@symmetricore.com>
Fri, 22 Jan 2010 21:22:41 +0000 (02:52 +0530)
committerGreg Kroah-Hartman <gregkh@suse.de>
Thu, 4 Mar 2010 00:42:52 +0000 (16:42 -0800)
Signed-off-by: Himanshu Chauhan <himanshu@symmetricore.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/staging/usbip/usbip_common.c

index 57c0ff5ab9a584b6b2e8092692f9cb3008579d0e..3367a52176942b4135da3424536317daee7f653f 100644 (file)
@@ -63,33 +63,8 @@ DEVICE_ATTR(usbip_debug, (S_IRUGO | S_IWUSR), show_flag, store_flag);
 
 static void usbip_dump_buffer(char *buff, int bufflen)
 {
-       int i;
-
-       if (bufflen > 128) {
-               for (i = 0; i < 128; i++) {
-                       if (i%24 == 0)
-                               printk(KERN_DEBUG "   ");
-                       printk(KERN_DEBUG "%02x ", (unsigned char) buff[i]);
-                       if (i%4 == 3)
-                               printk(KERN_DEBUG "| ");
-                       if (i%24 == 23)
-                               printk(KERN_DEBUG "\n");
-               }
-               printk(KERN_DEBUG "... (%d byte)\n", bufflen);
-               return;
-       }
-
-       for (i = 0; i < bufflen; i++) {
-               if (i%24 == 0)
-                       printk(KERN_DEBUG "   ");
-               printk(KERN_DEBUG "%02x ", (unsigned char) buff[i]);
-               if (i%4 == 3)
-                       printk(KERN_DEBUG "| ");
-               if (i%24 == 23)
-                       printk(KERN_DEBUG "\n");
-       }
-       printk(KERN_DEBUG "\n");
-
+       print_hex_dump(KERN_DEBUG, "usb-ip", DUMP_PREFIX_OFFSET, 16, 4,
+                      buff, bufflen, false);
 }
 
 static void usbip_dump_pipe(unsigned int p)