]> bbs.cooldavid.org Git - net-next-2.6.git/commitdiff
net: remove check for headroom in vlan_dev_create
authorJohn Fastabend <john.r.fastabend@intel.com>
Sat, 30 Oct 2010 14:22:37 +0000 (14:22 +0000)
committerDavid S. Miller <davem@davemloft.net>
Mon, 15 Nov 2010 18:11:40 +0000 (10:11 -0800)
It is possible for the headroom to be smaller then the
hard_header_len for a short period of time after toggling
the vlan offload setting.

This is not a hard error and skb_cow_head is called in
__vlan_put_tag() to resolve this.

Signed-off-by: John Fastabend <john.r.fastabend@intel.com>
Acked-by: Jesse Gross <jesse@nicira.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/8021q/vlan_dev.c

index 14e3d1fa07a0f70df457515f3aede2d31e77c9cb..afb03c5a7adc86aaed3a15e2b89f424dd26395f2 100644 (file)
@@ -274,9 +274,6 @@ static int vlan_dev_hard_header(struct sk_buff *skb, struct net_device *dev,
        u16 vlan_tci = 0;
        int rc;
 
-       if (WARN_ON(skb_headroom(skb) < dev->hard_header_len))
-               return -ENOSPC;
-
        if (!(vlan_dev_info(dev)->flags & VLAN_FLAG_REORDER_HDR)) {
                vhdr = (struct vlan_hdr *) skb_push(skb, VLAN_HLEN);