]> bbs.cooldavid.org Git - net-next-2.6.git/commitdiff
RDMA/cxgb4: Remove unneeded NULL check
authorRoland Dreier <rolandd@cisco.com>
Mon, 19 Jul 2010 20:13:09 +0000 (13:13 -0700)
committerRoland Dreier <rolandd@cisco.com>
Mon, 19 Jul 2010 20:13:09 +0000 (13:13 -0700)
The rest of the code seems to assume that ep->com.cm_id can't be NULL,
so remove an unneeded test.

Reported-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Roland Dreier <rolandd@cisco.com>
drivers/infiniband/hw/cxgb4/cm.c

index b5e676c61096c9a63b45d1761f6ef8538c56e775..4185c3b0635b31539b9566ae9cd1595cb2edbbe7 100644 (file)
@@ -780,11 +780,11 @@ static void connect_reply_upcall(struct c4iw_ep *ep, int status)
                event.private_data_len = ep->plen;
                event.private_data = ep->mpa_pkt + sizeof(struct mpa_message);
        }
-       if (ep->com.cm_id) {
-               PDBG("%s ep %p tid %u status %d\n", __func__, ep,
-                    ep->hwtid, status);
-               ep->com.cm_id->event_handler(ep->com.cm_id, &event);
-       }
+
+       PDBG("%s ep %p tid %u status %d\n", __func__, ep,
+            ep->hwtid, status);
+       ep->com.cm_id->event_handler(ep->com.cm_id, &event);
+
        if (status < 0) {
                ep->com.cm_id->rem_ref(ep->com.cm_id);
                ep->com.cm_id = NULL;