]> bbs.cooldavid.org Git - net-next-2.6.git/commitdiff
[SCSI] fcoe: Fix validation of mac address when checking for spma support
authorYi Zou <yi.zou@intel.com>
Thu, 30 Jul 2009 00:03:50 +0000 (17:03 -0700)
committerJames Bottomley <James.Bottomley@suse.de>
Sat, 22 Aug 2009 22:52:02 +0000 (17:52 -0500)
Fix this bug of validating the wrong mac address while checking for SAN MAC
address support from LLD as we should check ha->addr not ctlr.ctl_src_addr.

Signed-off-by: Yi Zou <yi.zou@intel.com>
Signed-off-by: Robert Love <robert.w.love@intel.com>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
drivers/scsi/fcoe/fcoe.c

index 0a5609bb58172edca3cc4190dba4b31df8ad7f75..b7dfc6ebed36be64d63883242421d4b7ade85182 100644 (file)
@@ -329,7 +329,7 @@ static int fcoe_netdev_config(struct fc_lport *lp, struct net_device *netdev)
        rcu_read_lock();
        for_each_dev_addr(netdev, ha) {
                if ((ha->type == NETDEV_HW_ADDR_T_SAN) &&
-                   (is_valid_ether_addr(fc->ctlr.ctl_src_addr))) {
+                   (is_valid_ether_addr(ha->addr))) {
                        memcpy(fc->ctlr.ctl_src_addr, ha->addr, ETH_ALEN);
                        fc->ctlr.spma = 1;
                        break;