]> bbs.cooldavid.org Git - net-next-2.6.git/commitdiff
netfilter: xtables: remove old comments about reentrancy
authorJan Engelhardt <jengelh@medozas.de>
Mon, 19 Apr 2010 14:07:47 +0000 (16:07 +0200)
committerPatrick McHardy <kaber@trash.net>
Mon, 19 Apr 2010 14:07:47 +0000 (16:07 +0200)
Signed-off-by: Jan Engelhardt <jengelh@medozas.de>
Signed-off-by: Patrick McHardy <kaber@trash.net>
net/ipv4/netfilter/ip_tables.c
net/ipv4/netfilter/ipt_REJECT.c
net/ipv6/netfilter/ip6_tables.c
net/ipv6/netfilter/ip6t_REJECT.c

index 70900ecf88e2166d47466770b54a874f416831d7..bb5e0d9b8137ca1c10179d082a602c5825e7502a 100644 (file)
@@ -434,8 +434,6 @@ ipt_do_table(struct sk_buff *skb,
                        continue;
                }
 
-               /* Targets which reenter must return
-                  abs. verdicts */
                tgpar.target   = t->u.kernel.target;
                tgpar.targinfo = t->data;
 
index b026014e7a5be1cfd8307d06561450a7984614b1..038fa0bb8f6b02d1e198f240c67133b3a6a2e6b8 100644 (file)
@@ -139,9 +139,6 @@ reject_tg(struct sk_buff *skb, const struct xt_target_param *par)
 {
        const struct ipt_reject_info *reject = par->targinfo;
 
-       /* WARNING: This code causes reentry within iptables.
-          This means that the iptables jump stack is now crap.  We
-          must return an absolute verdict. --RR */
        switch (reject->with) {
        case IPT_ICMP_NET_UNREACHABLE:
                send_unreach(skb, ICMP_NET_UNREACH);
index 2a2770bcd640a9ff442fc0b3a0eee8ae4ddd1fca..7afa117731648f9a1f584e5c9966f6824e3634c6 100644 (file)
@@ -451,8 +451,6 @@ ip6t_do_table(struct sk_buff *skb,
                        continue;
                }
 
-               /* Targets which reenter must return
-                  abs. verdicts */
                tgpar.target   = t->u.kernel.target;
                tgpar.targinfo = t->data;
 
index 55b9b2da134048670fc9f4a19a5b536f26d1f9f3..dad97622ed7223f13df5c68d686352fbb1dc9002 100644 (file)
@@ -179,9 +179,6 @@ reject_tg6(struct sk_buff *skb, const struct xt_target_param *par)
        struct net *net = dev_net((par->in != NULL) ? par->in : par->out);
 
        pr_debug("%s: medium point\n", __func__);
-       /* WARNING: This code causes reentry within ip6tables.
-          This means that the ip6tables jump stack is now crap.  We
-          must return an absolute verdict. --RR */
        switch (reject->with) {
        case IP6T_ICMP6_NO_ROUTE:
                send_unreach(net, skb, ICMPV6_NOROUTE, par->hooknum);