]> bbs.cooldavid.org Git - net-next-2.6.git/commitdiff
arch/tile: Fix bug in support for atomic64_xx() ops.
authorChris Metcalf <cmetcalf@tilera.com>
Fri, 25 Jun 2010 21:02:40 +0000 (17:02 -0400)
committerChris Metcalf <cmetcalf@tilera.com>
Tue, 6 Jul 2010 17:41:39 +0000 (13:41 -0400)
This wasn't properly tested until the perf-event subsystem started
to get brought up under the tile architecture.

The bug caused bogus atomic64_cmpxchg() values to be returned,
among other things.

Signed-off-by: Chris Metcalf <cmetcalf@tilera.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
arch/tile/lib/atomic_asm_32.S

index c0d058578192f2863137b02229cedc15bfadc38f..5a5514b77e783d5ebe0dc7455c7ed4e17f592a84 100644 (file)
@@ -89,11 +89,11 @@ STD_ENTRY_SECTION(__atomic\name, .text.atomic)
         lh     r22, r0
         .else
         lw     r22, r0
-        addi   r23, r0, 4
+        addi   r28, r0, 4
         .endif
        }
        .ifc \bitwidth,64
-       lw      r23, r23
+       lw      r23, r28
        .endif
        \body /* set r24, and r25 if 64-bit */
        {
@@ -109,11 +109,10 @@ STD_ENTRY_SECTION(__atomic\name, .text.atomic)
         sh     r0, r24
         .else
         sw     r0, r24
-        addi   r23, r0, 4
         .endif
        }
        .ifc \bitwidth,64
-       sw      r23, r25
+       sw      r28, r25
        .endif
        mf
 3:     {