]> bbs.cooldavid.org Git - net-next-2.6.git/commitdiff
tracing: Do not reset *pos in set_ftrace_filter
authorSteven Rostedt <srostedt@redhat.com>
Thu, 9 Sep 2010 12:43:22 +0000 (08:43 -0400)
committerSteven Rostedt <rostedt@goodmis.org>
Tue, 14 Sep 2010 15:42:29 +0000 (11:42 -0400)
After the filtered functions are read, the probed functions are read
from the hash in set_ftrace_filter. When the hashed probed functions
are read, the *pos passed in is reset. Instead of modifying the pos
given to the read function, just record the pos where the filtered
functions ended and subtract from that.

Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
kernel/trace/ftrace.c

index fa7ece649fe1bcad7b0db621fa8579e91860fb04..585ea27025b1c4d37737b77af64a38f441f54d75 100644 (file)
@@ -1368,6 +1368,7 @@ enum {
 #define FTRACE_BUFF_MAX (KSYM_SYMBOL_LEN+4) /* room for wildcards */
 
 struct ftrace_iterator {
+       loff_t                  func_pos;
        struct ftrace_page      *pg;
        int                     hidx;
        int                     idx;
@@ -1418,12 +1419,15 @@ static void *t_hash_start(struct seq_file *m, loff_t *pos)
        loff_t l;
 
        if (!(iter->flags & FTRACE_ITER_HASH))
-               *pos = 0;
+               iter->func_pos = *pos;
+
+       if (iter->func_pos > *pos)
+               return NULL;
 
        iter->flags |= FTRACE_ITER_HASH;
 
        iter->hidx = 0;
-       for (l = 0; l <= *pos; ) {
+       for (l = 0; l <= (*pos - iter->func_pos); ) {
                p = t_hash_next(m, p, &l);
                if (!p)
                        break;