]> bbs.cooldavid.org Git - net-next-2.6.git/commitdiff
IB/qib: Use generic_file_llseek
authorArnd Bergmann <arnd@arndb.de>
Wed, 7 Jul 2010 21:40:06 +0000 (21:40 +0000)
committerRoland Dreier <rolandd@cisco.com>
Wed, 21 Jul 2010 18:39:27 +0000 (11:39 -0700)
When the default llseek action gets changed to no_llseek, all file
systems relying on the current behaviour need to set explicit .llseek
operations.

In case of qib_fs, we want the files to be seekable, so
generic_file_llseek fits best.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Roland Dreier <rolandd@cisco.com>
drivers/infiniband/hw/qib/qib_fs.c

index 844954bf417b7cc10fd13a3c103388b4099e8f79..9f989c0ba9d302fd7d643d4a5389e012d44559a5 100644 (file)
@@ -135,8 +135,8 @@ static ssize_t driver_names_read(struct file *file, char __user *buf,
 }
 
 static const struct file_operations driver_ops[] = {
-       { .read = driver_stats_read, },
-       { .read = driver_names_read, },
+       { .read = driver_stats_read, .llseek = generic_file_llseek, },
+       { .read = driver_names_read, .llseek = generic_file_llseek, },
 };
 
 /* read the per-device counters */
@@ -164,8 +164,8 @@ static ssize_t dev_names_read(struct file *file, char __user *buf,
 }
 
 static const struct file_operations cntr_ops[] = {
-       { .read = dev_counters_read, },
-       { .read = dev_names_read, },
+       { .read = dev_counters_read, .llseek = generic_file_llseek, },
+       { .read = dev_names_read, .llseek = generic_file_llseek, },
 };
 
 /*
@@ -210,9 +210,9 @@ static ssize_t portcntrs_2_read(struct file *file, char __user *buf,
 }
 
 static const struct file_operations portcntr_ops[] = {
-       { .read = portnames_read, },
-       { .read = portcntrs_1_read, },
-       { .read = portcntrs_2_read, },
+       { .read = portnames_read, .llseek = generic_file_llseek, },
+       { .read = portcntrs_1_read, .llseek = generic_file_llseek, },
+       { .read = portcntrs_2_read, .llseek = generic_file_llseek, },
 };
 
 /*
@@ -261,8 +261,8 @@ static ssize_t qsfp_2_read(struct file *file, char __user *buf,
 }
 
 static const struct file_operations qsfp_ops[] = {
-       { .read = qsfp_1_read, },
-       { .read = qsfp_2_read, },
+       { .read = qsfp_1_read, .llseek = generic_file_llseek, },
+       { .read = qsfp_2_read, .llseek = generic_file_llseek, },
 };
 
 static ssize_t flash_read(struct file *file, char __user *buf,