]> bbs.cooldavid.org Git - net-next-2.6.git/commitdiff
V4L/DVB: drivers/media/dvb/frontends: remove duplicate structure field initialization
authorJulia Lawall <julia@diku.dk>
Sun, 20 Jun 2010 13:40:37 +0000 (10:40 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Mon, 2 Aug 2010 18:29:18 +0000 (15:29 -0300)
The read_status field is initialized twice to the same value.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@r@
identifier I, s, fld;
position p0,p;
expression E;
@@

struct I s =@p0 { ... .fld@p = E, ...};

@s@
identifier I, s, r.fld;
position r.p0,p;
expression E;
@@

struct I s =@p0 { ... .fld@p = E, ...};

@script:python@
p0 << r.p0;
fld << r.fld;
ps << s.p;
pr << r.p;
@@

if int(ps[0].line)<int(pr[0].line) or int(ps[0].column)<int(pr[0].column):
  cocci.print_main(fld,p0)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/dvb/frontends/mb86a16.c

index 599d1aa519a31ca160306471c237a1ba362a7ba3..33b63235b86e993f32e8489a87d2be7879d41641 100644 (file)
@@ -1833,7 +1833,6 @@ static struct dvb_frontend_ops mb86a16_ops = {
 
        .get_frontend_algo              = mb86a16_frontend_algo,
        .search                         = mb86a16_search,
-       .read_status                    = mb86a16_read_status,
        .init                           = mb86a16_init,
        .sleep                          = mb86a16_sleep,
        .read_status                    = mb86a16_read_status,