]> bbs.cooldavid.org Git - net-next-2.6.git/commitdiff
USB-BKL: Remove lock_kernel in usbfs update_sb()
authorAndi Kleen <ak@linux.intel.com>
Tue, 1 Jun 2010 21:04:40 +0000 (23:04 +0200)
committerGreg Kroah-Hartman <gregkh@suse.de>
Tue, 10 Aug 2010 21:35:35 +0000 (14:35 -0700)
The code this is attempting to lock against does not use the BKL,
so it's not needed.

Most likely this code is still broken/racy (Al Viro also thinks so),
but removing the BKL should not make it worse than before.

Signed-off-by: Andi Kleen <ak@linux.intel.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/usb/core/inode.c

index 1a27618b67d61dec116025db0a35e015a1569c7f..095fa53666909e02e2325badb15bfe5f63dc139b 100644 (file)
@@ -265,13 +265,9 @@ static int remount(struct super_block *sb, int *flags, char *data)
                return -EINVAL;
        }
 
-       lock_kernel();
-
        if (usbfs_mount && usbfs_mount->mnt_sb)
                update_sb(usbfs_mount->mnt_sb);
 
-       unlock_kernel();
-
        return 0;
 }