]> bbs.cooldavid.org Git - net-next-2.6.git/commitdiff
davinci: make it easier to identify SoC init failures
authorSekhar Nori <nsekhar@ti.com>
Thu, 1 Oct 2009 07:11:06 +0000 (12:41 +0530)
committerKevin Hilman <khilman@deeprootsystems.com>
Wed, 25 Nov 2009 18:21:31 +0000 (10:21 -0800)
This patch makes it easier to identify SoC init failures
by panicing when SoC init fails. Without successful SoC
init, the kernel eventually fails when attempt is made to
access the clocks.

Also, an error is printed when JTAG ID match fails to make
it easier to identify failures due to SoC rev changes.

Signed-off-by: Sekhar Nori <nsekhar@ti.com>
Signed-off-by: Kevin Hilman <khilman@deeprootsystems.com>
arch/arm/mach-davinci/common.c

index 61ede19c6b544766dc05008446eb7945d332c486..c2de94cde56a85bba11ddc02031ced7876fdc3f4 100644 (file)
@@ -86,6 +86,8 @@ void __init davinci_common_init(struct davinci_soc_info *soc_info)
        dip = davinci_get_id(davinci_soc_info.jtag_id);
        if (!dip) {
                ret = -EINVAL;
+               pr_err("Unknown DaVinci JTAG ID 0x%x\n",
+                                               davinci_soc_info.jtag_id);
                goto err;
        }
 
@@ -104,5 +106,5 @@ void __init davinci_common_init(struct davinci_soc_info *soc_info)
        return;
 
 err:
-       pr_err("davinci_common_init: SoC Initialization failed\n");
+       panic("davinci_common_init: SoC Initialization failed\n");
 }