]> bbs.cooldavid.org Git - net-next-2.6.git/commitdiff
x86, tsc: Fix a preemption leak in restore_sched_clock_state()
authorPeter Zijlstra <peterz@infradead.org>
Fri, 10 Sep 2010 20:32:53 +0000 (22:32 +0200)
committerLinus Torvalds <torvalds@linux-foundation.org>
Sat, 11 Sep 2010 01:17:45 +0000 (18:17 -0700)
A real life genuine preemption leak..

Reported-and-tested-by: Jeff Chua <jeff.chua.linux@gmail.com>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Acked-by: Suresh Siddha <suresh.b.siddha@intel.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
arch/x86/kernel/tsc.c

index d632934cb6386947352650f262745eb3c93c68ce..26a863a9c2a815ec797b6211cd3de5e0b9cbed8e 100644 (file)
@@ -655,7 +655,7 @@ void restore_sched_clock_state(void)
 
        local_irq_save(flags);
 
-       get_cpu_var(cyc2ns_offset) = 0;
+       __get_cpu_var(cyc2ns_offset) = 0;
        offset = cyc2ns_suspend - sched_clock();
 
        for_each_possible_cpu(cpu)