]> bbs.cooldavid.org Git - net-next-2.6.git/commitdiff
PCI: hotplug/shpchp_hpc: add parenthesis in SLOT_REG_RSVDZ_MASK
authorDan Carpenter <error27@gmail.com>
Wed, 26 May 2010 10:46:39 +0000 (12:46 +0200)
committerJesse Barnes <jbarnes@virtuousgeek.org>
Fri, 30 Jul 2010 16:29:10 +0000 (09:29 -0700)
The SLOT_REG_RSVDZ_MASK macro is normally used like this:
slot_reg &= ~SLOT_REG_RSVDZ_MASK;
The ~ operator has higher precedence than the | operator from inside the
macro, so it needs parenthesis.

Reviewed-by: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
drivers/pci/hotplug/shpchp_hpc.c

index 5f5e8d2e35529a2ca9ec92be86eda94f28b4e86f..d3985e7deab7db44f8e2674f34da37a810c2d06d 100644 (file)
 #define CON_PFAULT_INTR_MASK   (1 << 28)
 #define MRL_CHANGE_SERR_MASK   (1 << 29)
 #define CON_PFAULT_SERR_MASK   (1 << 30)
-#define SLOT_REG_RSVDZ_MASK    (1 << 15) | (7 << 21)
+#define SLOT_REG_RSVDZ_MASK    ((1 << 15) | (7 << 21))
 
 /*
  * SHPC Command Code definitnions