quota: unify quota init condition in setattr

Quota must being initialized if size or uid/git changes requested.
But initialization performed in two different places:
in case of i_size file system is responsible for dquot init
, but in case of uid/gid init will be called internally in
dquot_transfer().
This ambiguity makes code harder to understand.
Let's move this logic to one common helper function.

Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org>
Signed-off-by: Jan Kara <jack@suse.cz>

diff --git a/fs/ext2/inode.c b/fs/ext2/inode.c
index b90c3bf6e9ba35a528e073ce545a5e67a909ca73..527c46d9bc1f035148ab5cb8598954feac481ede 100644 (file)
--- a/fs/ext2/inode.c
+++ b/fs/ext2/inode.c
@@ -1466,7 +1466,7 @@ int ext2_setattr(struct dentry *dentry, struct iattr *iattr)
        if (error)
                return error;
 
-       if (iattr->ia_valid & ATTR_SIZE)
+       if (is_quota_modification(inode, iattr))
                dquot_initialize(inode);
        if ((iattr->ia_valid & ATTR_UID && iattr->ia_uid != inode->i_uid) ||
            (iattr->ia_valid & ATTR_GID && iattr->ia_gid != inode->i_gid)) {

diff --git a/fs/ext3/inode.c b/fs/ext3/inode.c
index ea33bdf0a3004b927c10be9289b21125dcf53c38..735f0190ec2abe8dd68320cf5dc0a188f67af9c9 100644 (file)
--- a/fs/ext3/inode.c
+++ b/fs/ext3/inode.c
@@ -3151,7 +3151,7 @@ int ext3_setattr(struct dentry *dentry, struct iattr *attr)
        if (error)
                return error;
 
-       if (ia_valid & ATTR_SIZE)
+       if (is_quota_modification(inode, attr))
                dquot_initialize(inode);
        if ((ia_valid & ATTR_UID && attr->ia_uid != inode->i_uid) ||
                (ia_valid & ATTR_GID && attr->ia_gid != inode->i_gid)) {

diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index 81d605412844895c4386c92c0f4920db39acbd94..3e0f6af9d08d9a6faf3bea7c25087b94b8b883b0 100644 (file)
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -5425,7 +5425,7 @@ int ext4_setattr(struct dentry *dentry, struct iattr *attr)
        if (error)
                return error;
 
-       if (ia_valid & ATTR_SIZE)
+       if (is_quota_modification(inode, attr))
                dquot_initialize(inode);
        if ((ia_valid & ATTR_UID && attr->ia_uid != inode->i_uid) ||
                (ia_valid & ATTR_GID && attr->ia_gid != inode->i_gid)) {

diff --git a/fs/jfs/file.c b/fs/jfs/file.c
index 14ba982b3f24f96c60f45472749816d17eea0194..85d9ec6592250231fd4c299fd7cabe3a7ec9049e 100644 (file)
--- a/fs/jfs/file.c
+++ b/fs/jfs/file.c
@@ -98,7 +98,7 @@ int jfs_setattr(struct dentry *dentry, struct iattr *iattr)
        if (rc)
                return rc;
 
-       if (iattr->ia_valid & ATTR_SIZE)
+       if (is_quota_modification(inode, iattr))
                dquot_initialize(inode);
        if ((iattr->ia_valid & ATTR_UID && iattr->ia_uid != inode->i_uid) ||
            (iattr->ia_valid & ATTR_GID && iattr->ia_gid != inode->i_gid)) {

diff --git a/fs/ocfs2/file.c b/fs/ocfs2/file.c
index f74f1400eccda0cf0348b5fa0aae4e5d0c9f923f..e127c53ec2e7a5f33be2ce442272d0531832d81b 100644 (file)
--- a/fs/ocfs2/file.c
+++ b/fs/ocfs2/file.c
@@ -966,10 +966,10 @@ int ocfs2_setattr(struct dentry *dentry, struct iattr *attr)
        if (status)
                return status;
 
+       if (is_quota_modification(inode, attr))
+               dquot_initialize(inode);
        size_change = S_ISREG(inode->i_mode) && attr->ia_valid & ATTR_SIZE;
        if (size_change) {
-               dquot_initialize(inode);
-
                status = ocfs2_rw_lock(inode, 1);
                if (status < 0) {
                        mlog_errno(status);

diff --git a/fs/quota/dquot.c b/fs/quota/dquot.c
index b1a5036560a94aa2101310a8e6eb94e1ca86f2f3..1056a21f0300c994e2cc56e147278ea869e278bb 100644 (file)
--- a/fs/quota/dquot.c
+++ b/fs/quota/dquot.c
@@ -1822,10 +1822,9 @@ int dquot_transfer(struct inode *inode, struct iattr *iattr)
                mask |= 1 << GRPQUOTA;
                chid[GRPQUOTA] = iattr->ia_gid;
        }
-       if (sb_any_quota_active(inode->i_sb) && !IS_NOQUOTA(inode)) {
-               dquot_initialize(inode);
+       if (sb_any_quota_active(inode->i_sb) && !IS_NOQUOTA(inode))
                return __dquot_transfer(inode, chid, mask);
-       }
+
        return 0;
 }
 EXPORT_SYMBOL(dquot_transfer);

diff --git a/fs/reiserfs/inode.c b/fs/reiserfs/inode.c
index dc2c65e04853b8750d0a1fad38ea5521daa185af..0f22fdaf54ac037ecc21dea052d135d340a5d510 100644 (file)
--- a/fs/reiserfs/inode.c
+++ b/fs/reiserfs/inode.c
@@ -3076,9 +3076,10 @@ int reiserfs_setattr(struct dentry *dentry, struct iattr *attr)
        ia_valid = attr->ia_valid &= ~(ATTR_KILL_SUID|ATTR_KILL_SGID);
 
        depth = reiserfs_write_lock_once(inode->i_sb);
-       if (attr->ia_valid & ATTR_SIZE) {
+       if (is_quota_modification(inode, attr))
                dquot_initialize(inode);
 
+       if (attr->ia_valid & ATTR_SIZE) {
                /* version 2 items will be caught by the s_maxbytes check
                 ** done for us in vmtruncate
                 */

diff --git a/fs/udf/file.c b/fs/udf/file.c
index 4b6a46ccbf46771d7b363974c2416b8f63a7b946..6ebc043f3a2ac791e2a6d157a4da9e5b51147c7a 100644 (file)
--- a/fs/udf/file.c
+++ b/fs/udf/file.c
@@ -227,7 +227,7 @@ int udf_setattr(struct dentry *dentry, struct iattr *iattr)
        if (error)
                return error;
 
-       if (iattr->ia_valid & ATTR_SIZE)
+       if (is_quota_modification(inode, iattr))
                dquot_initialize(inode);
 
        if ((iattr->ia_valid & ATTR_UID && iattr->ia_uid != inode->i_uid) ||

diff --git a/fs/ufs/truncate.c b/fs/ufs/truncate.c
index ee8db3e77bfedd74f067f0d7352bc464f7703482..f294c44577dced33302a121561a8c65815da4a8c 100644 (file)
--- a/fs/ufs/truncate.c
+++ b/fs/ufs/truncate.c
@@ -518,18 +518,18 @@ int ufs_setattr(struct dentry *dentry, struct iattr *attr)
        if (error)
                return error;
 
+       if (is_quota_modification(inode, attr))
+               dquot_initialize(inode);
+
        if ((ia_valid & ATTR_UID && attr->ia_uid != inode->i_uid) ||
            (ia_valid & ATTR_GID && attr->ia_gid != inode->i_gid)) {
                error = dquot_transfer(inode, attr);
                if (error)
                        return error;
        }
-       if (ia_valid & ATTR_SIZE &&
-           attr->ia_size != i_size_read(inode)) {
+       if (ia_valid & ATTR_SIZE && attr->ia_size != inode->i_size) {
                loff_t old_i_size = inode->i_size;
 
-               dquot_initialize(inode);
-
                error = vmtruncate(inode, attr->ia_size);
                if (error)
                        return error;

diff --git a/include/linux/quotaops.h b/include/linux/quotaops.h
index 82c70c42d0353de628631be1236b67a429f3fb7f..8a7818764a678118ed8d2d8358657a5b4042ec1f 100644 (file)
--- a/include/linux/quotaops.h
+++ b/include/linux/quotaops.h
@@ -14,6 +14,14 @@ static inline struct quota_info *sb_dqopt(struct super_block *sb)
        return &sb->s_dquot;
 }
 
+/* i_mutex must being held */
+static inline bool is_quota_modification(struct inode *inode, struct iattr *ia)
+{
+       return (ia->ia_valid & ATTR_SIZE && ia->ia_size != inode->i_size) ||
+               (ia->ia_valid & ATTR_UID && ia->ia_uid != inode->i_uid) ||
+               (ia->ia_valid & ATTR_GID && ia->ia_gid != inode->i_gid);
+}
+
 #if defined(CONFIG_QUOTA)
 
 /*