]> bbs.cooldavid.org Git - net-next-2.6.git/commitdiff
OMAP3: serial: Use dev_* macros instead of printk
authorSergio Aguirre <saaguirre@ti.com>
Tue, 9 Mar 2010 19:22:14 +0000 (13:22 -0600)
committerSergio Aguirre <saaguirre@ti.com>
Mon, 15 Mar 2010 21:34:12 +0000 (16:34 -0500)
As we have a struct device populated at the time we are
printing the errors, using dev_* macros makes more sense,
as could give a better idea where the error/warning came from.

Signed-off-by: Sergio Aguirre <saaguirre@ti.com>
arch/arm/mach-omap2/serial.c

index ef91fc0390b4be5de788866f7293cfc3133775ab..a55e6aeb648eea6324b8927c53bf9562bffa02cf 100644 (file)
@@ -550,7 +550,7 @@ static ssize_t sleep_timeout_store(struct device *dev,
        unsigned int value;
 
        if (sscanf(buf, "%u", &value) != 1) {
-               printk(KERN_ERR "sleep_timeout_store: Invalid value\n");
+               dev_err(dev, "sleep_timeout_store: Invalid value\n");
                return -EINVAL;
        }
 
@@ -666,8 +666,8 @@ void __init omap_serial_early_init(void)
 
                /* Don't map zero-based physical address */
                if (p->mapbase == 0) {
-                       printk(KERN_WARNING "omap serial: No physical address"
-                              " for uart#%d, so skipping early_init...\n", i);
+                       dev_warn(dev, "no physical address for uart#%d,"
+                                " so skipping early_init...\n", i);
                        continue;
                }
                /*
@@ -676,21 +676,21 @@ void __init omap_serial_early_init(void)
                 */
                p->membase = ioremap(p->mapbase, SZ_8K);
                if (!p->membase) {
-                       printk(KERN_ERR "ioremap failed for uart%i\n", i + 1);
+                       dev_err(dev, "ioremap failed for uart%i\n", i + 1);
                        continue;
                }
 
                sprintf(name, "uart%d_ick", i + 1);
                uart->ick = clk_get(NULL, name);
                if (IS_ERR(uart->ick)) {
-                       printk(KERN_ERR "Could not get uart%d_ick\n", i + 1);
+                       dev_err(dev, "Could not get uart%d_ick\n", i + 1);
                        uart->ick = NULL;
                }
 
                sprintf(name, "uart%d_fck", i+1);
                uart->fck = clk_get(NULL, name);
                if (IS_ERR(uart->fck)) {
-                       printk(KERN_ERR "Could not get uart%d_fck\n", i + 1);
+                       dev_err(dev, "Could not get uart%d_fck\n", i + 1);
                        uart->fck = NULL;
                }