]> bbs.cooldavid.org Git - net-next-2.6.git/commitdiff
drm: move dereference below check
authorDan Carpenter <error27@gmail.com>
Thu, 19 Aug 2010 09:46:29 +0000 (11:46 +0200)
committerDave Airlie <airlied@redhat.com>
Thu, 19 Aug 2010 22:48:44 +0000 (08:48 +1000)
"fb_helper_conn" is dereferenced before the check for NULL.  It's never
actually NULL here, so this is mostly to keep the static checkers happy.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
drivers/gpu/drm/drm_fb_helper.c

index 719662034bbfee9d9d1f2be26bfe1199c985d0a0..cef8d8da5952b294827bb7dc9e6b36abecbb2e3b 100644 (file)
@@ -94,10 +94,11 @@ static bool drm_fb_helper_connector_parse_command_line(struct drm_fb_helper_conn
        int i;
        enum drm_connector_force force = DRM_FORCE_UNSPECIFIED;
        struct drm_fb_helper_cmdline_mode *cmdline_mode;
-       struct drm_connector *connector = fb_helper_conn->connector;
+       struct drm_connector *connector;
 
        if (!fb_helper_conn)
                return false;
+       connector = fb_helper_conn->connector;
 
        cmdline_mode = &fb_helper_conn->cmdline_mode;
        if (!mode_option)