From a7cd5829d8b3837755105d71f76a75cddf49003f Mon Sep 17 00:00:00 2001 From: Shan Wei Date: Fri, 24 Jul 2009 16:57:35 +0800 Subject: [PATCH] Staging: usb-ip: vhci_hdc:Fix the returned error value Compared with other drivers, the "ret" should be nagative and returned. But in vhci_hdc, it always return 0; I dont't use the driver, and I'm not familiar with the code. Hope the patch is helpful. Signed-off-by: Shan Wei Signed-off-by: Greg Kroah-Hartman --- drivers/staging/usbip/vhci_hcd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/usbip/vhci_hcd.c b/drivers/staging/usbip/vhci_hcd.c index 114db8b2602..6e91fc2bd85 100644 --- a/drivers/staging/usbip/vhci_hcd.c +++ b/drivers/staging/usbip/vhci_hcd.c @@ -594,7 +594,7 @@ static int vhci_urb_enqueue(struct usb_hcd *hcd, struct urb *urb, if (type != PIPE_CONTROL || !ctrlreq) { dev_err(dev, "invalid request to devnum 0\n"); - ret = EINVAL; + ret = -EINVAL; goto no_need_xmit; } @@ -653,7 +653,7 @@ no_need_unlink: usb_hcd_giveback_urb(vhci_to_hcd(the_controller), urb, urb->status); - return 0; + return ret; } /* -- 2.39.3