]> bbs.cooldavid.org Git - net-next-2.6.git/commit
mac80211: Remove redundant checks for NULL before calls to crypto_free_cipher()
authorJesper Juhl <jj@chaosbits.net>
Thu, 4 Nov 2010 21:59:56 +0000 (22:59 +0100)
committerJohn W. Linville <linville@tuxdriver.com>
Mon, 15 Nov 2010 18:26:11 +0000 (13:26 -0500)
commitffa56e540c3949c4560dcce45eca247819e183c1
tree014fb3286ef0e879c6b78196ded7c87baccde252
parent723fc7af5300dba9eac40cb23dbefa67589e5181
mac80211: Remove redundant checks for NULL before calls to crypto_free_cipher()

crypto_free_cipher() is a wrapper around crypto_free_tfm() which is a
wrapper around crypto_destroy_tfm() and the latter can handle being passed
a NULL pointer, so checking for NULL in the
ieee80211_aes_key_free()/ieee80211_aes_cmac_key_free() wrappers around
crypto_free_cipher() is pointless and just increase object code size
needlesly and makes us execute extra test/branch instructions that we
don't need.
Btw; don't we have to many wrappers around wrappers ad nauseam here?
Anyway, this patch removes the redundant conditionals.

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
net/mac80211/aes_ccm.c
net/mac80211/aes_cmac.c