]> bbs.cooldavid.org Git - net-next-2.6.git/commit
powerpc: Initialise paca->kstack before early_setup_secondary
authorMatt Evans <matt@ozlabs.org>
Thu, 12 Aug 2010 20:58:28 +0000 (20:58 +0000)
committerBenjamin Herrenschmidt <benh@kernel.crashing.org>
Tue, 24 Aug 2010 05:26:31 +0000 (15:26 +1000)
commitf761622e59433130bc33ad086ce219feee9eb961
tree5368ebf02c7879d98d3158a2ff9ba3b612a5b471
parent7aa241fdcef2a1d6587fe4c390e9fdbfc767af28
powerpc: Initialise paca->kstack before early_setup_secondary

As early setup calls down to slb_initialize(), we must have kstack
initialised before checking "should we add a bolted SLB entry for our kstack?"

Failing to do so means stack access requires an SLB miss exception to refill
an entry dynamically, if the stack isn't accessible via SLB(0) (kernel text
& static data).  It's not always allowable to take such a miss, and
intermittent crashes will result.

Primary CPUs don't have this issue; an SLB entry is not bolted for their
stack anyway (as that lives within SLB(0)).  This patch therefore only
affects the init of secondaries.

Signed-off-by: Matt Evans <matt@ozlabs.org>
Cc: stable <stable@kernel.org>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
arch/powerpc/kernel/head_64.S