]> bbs.cooldavid.org Git - net-next-2.6.git/commit
lib/list_sort: do not pass bad pointers to cmp callback
authorDon Mullis <don.mullis@gmail.com>
Thu, 30 Sep 2010 22:15:32 +0000 (15:15 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Fri, 1 Oct 2010 17:50:58 +0000 (10:50 -0700)
commitf015ac3edd84ad72f88e08a4d83c56c360aae404
tree87f88c4e502d69752776dd36451d0ece5416f9f1
parent982f7c2b2e6a28f8f266e075d92e19c0dd4c6e56
lib/list_sort: do not pass bad pointers to cmp callback

If the original list is a POT in length, the first callback from line 73
will pass a==b both pointing to the original list_head.  This is dangerous
because the 'list_sort()' user can use 'container_of()' and accesses the
"containing" object, which does not necessary exist for the list head.  So
the user can access RAM which does not belong to him.  If this is a write
access, we can end up with memory corruption.

Signed-off-by: Don Mullis <don.mullis@gmail.com>
Tested-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
Cc: <stable@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
lib/list_sort.c