]> bbs.cooldavid.org Git - net-next-2.6.git/commit
xen: handle events as edge-triggered
authorJeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
Sat, 21 Aug 2010 02:10:01 +0000 (19:10 -0700)
committerJeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
Tue, 24 Aug 2010 18:14:12 +0000 (11:14 -0700)
commitdffe2e1e1a1ddb566a76266136c312801c66dcf7
tree2c78da36fc090fff84ff316899f261d221155136
parentaaca49642b92c8a57d3ca5029a5a94019c7af69f
xen: handle events as edge-triggered

Xen events are logically edge triggered, as Xen only calls the event
upcall when an event is newly set, but not continuously as it remains set.
As a result, use handle_edge_irq rather than handle_level_irq.

This has the important side-effect of fixing a long-standing bug of
events getting lost if:
 - an event's interrupt handler is running
 - the event is migrated to a different vcpu
 - the event is re-triggered

The most noticable symptom of these lost events is occasional lockups
of blkfront.

Many thanks to Tom Kopec and Daniel Stodden in tracking this down.

Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
Cc: Tom Kopec <tek@acm.org>
Cc: Daniel Stodden <daniel.stodden@citrix.com>
Cc: Stable Kernel <stable@kernel.org>
drivers/xen/events.c