]> bbs.cooldavid.org Git - net-next-2.6.git/commit
tg3: Fix some checkpatch errors
authorMatt Carlson <mcarlson@broadcom.com>
Sun, 11 Jul 2010 09:31:46 +0000 (09:31 +0000)
committerDavid S. Miller <davem@davemloft.net>
Mon, 12 Jul 2010 00:07:43 +0000 (17:07 -0700)
commitbe98da6a10f3e7f855f36f3fdd67a91366cabc1c
tree685268063d555928db246d635ad8ec16f330891a
parent702e52ccd32164a09ea91aa5896ad7c64cb708cb
tg3: Fix some checkpatch errors

This patch fixes the following checkpatch errors:

ERROR: do not use assignment in if condition
+ if ((mss = skb_shinfo(skb)->gso_size) != 0) {

ERROR: do not use assignment in if condition
+ if ((mss = skb_shinfo(skb)->gso_size) != 0) {

ERROR: space prohibited after that '!' (ctx:BxW)
+ if (! netif_carrier_ok(tp->dev) &&
      ^

ERROR: space required after that ',' (ctx:VxV)
+#define GET_REG32_LOOP(base,len) \
                            ^

ERROR: "(foo*)" should be "(foo *)"
+ memcpy(data, ((char*)&val) + b_offset, b_count);

ERROR: do not use assignment in if condition
+ if ((err = tg3_do_mem_test(tp, mem_tbl[i].offset,

Signed-off-by: Matt Carlson <mcarlson@broadcom.com>
Reviewed-by: Michael Chan <mchan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/tg3.c