]> bbs.cooldavid.org Git - net-next-2.6.git/commit
signals: annotate lock_task_sighand()
authorNamhyung Kim <namhyung@gmail.com>
Wed, 27 Oct 2010 22:34:06 +0000 (15:34 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Thu, 28 Oct 2010 01:03:12 +0000 (18:03 -0700)
commitb8ed374e202e23caaf9bd77dcadc9de6447faaa8
treeea97fe186c7e0c0ee8cd61e0fc94dc42f635fd3b
parent5ef45079dd9c8f2e9c7aa788dc3121835ae52863
signals: annotate lock_task_sighand()

lock_task_sighand() grabs sighand->siglock in case of returning non-NULL
but unlock_task_sighand() releases it unconditionally.  This leads sparse
to complain about the lock context imbalance.  Rename and wrap
lock_task_sighand() using __cond_lock() macro to make sparse happy.

Suggested-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: Namhyung Kim <namhyung@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Roland McGrath <roland@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
include/linux/sched.h
kernel/signal.c