]> bbs.cooldavid.org Git - net-next-2.6.git/commit
tcp: Increase TCP_MAXSEG socket option minimum.
authorDavid S. Miller <davem@davemloft.net>
Thu, 11 Nov 2010 05:35:37 +0000 (21:35 -0800)
committerDavid S. Miller <davem@davemloft.net>
Thu, 11 Nov 2010 05:35:37 +0000 (21:35 -0800)
commit7a1abd08d52fdeddb3e9a5a33f2f15cc6a5674d2
treef566af2a622e5416056c70633576a1a46b8bf6aa
parent8d987e5c75107ca7515fa19e857cfa24aab6ec8f
tcp: Increase TCP_MAXSEG socket option minimum.

As noted by Steve Chen, since commit
f5fff5dc8a7a3f395b0525c02ba92c95d42b7390 ("tcp: advertise MSS
requested by user") we can end up with a situation where
tcp_select_initial_window() does a divide by a zero (or
even negative) mss value.

The problem is that sometimes we effectively subtract
TCPOLEN_TSTAMP_ALIGNED and/or TCPOLEN_MD5SIG_ALIGNED from the mss.

Fix this by increasing the minimum from 8 to 64.

Reported-by: Steve Chen <schen@mvista.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/tcp.c