]> bbs.cooldavid.org Git - net-next-2.6.git/commit
alpha: fix hae_cache race in RESTORE_ALL
authorAl Viro <viro@zeniv.linux.org.uk>
Sat, 25 Sep 2010 20:07:14 +0000 (21:07 +0100)
committerLinus Torvalds <torvalds@linux-foundation.org>
Sat, 25 Sep 2010 21:38:13 +0000 (14:38 -0700)
commit77edffb652b33a565e099ff0a1687762f03eb46a
tree1e6e9586fc563d867c8737feb855575314deaff7
parent56162badadb91aae93843d8d6558c7d7780e3cb2
alpha: fix hae_cache race in RESTORE_ALL

We want interrupts disabled on all paths leading to RESTORE_ALL;
otherwise, we are risking an IRQ coming between the updates of
alpha_mv->hae_cache and *alpha_mv->hae_register and set_hae()
within the IRQ getting badly confused.

RESTORE_ALL used to play with disabling IRQ itself, but that got
removed back in 2002, without making sure we had them disabled
on all paths.  It's cheaper to make sure we have them disabled than
to revert to original variant...

Remove the detritus left from that commit back in 2002; we used to
need a reload of $0 and $1 since swpipl would change those, but
doing that had become pointless when we stopped doing swpipl in
there...

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
arch/alpha/kernel/entry.S