]> bbs.cooldavid.org Git - net-next-2.6.git/commit
ixgbe: fix issues with failing to detect insert of unsupported module
authorDon Skidmore <donald.c.skidmore@intel.com>
Thu, 2 Jul 2009 12:50:12 +0000 (12:50 +0000)
committerDavid S. Miller <davem@davemloft.net>
Sat, 4 Jul 2009 02:10:55 +0000 (19:10 -0700)
commit63d6e1d80a8c3118be2ca0f1f21ba883f282060c
treea1bd149312f64d88b7e1acf585568964b6ed805f
parente332471c035708441de89d4c59f7f7cdc2700c0d
ixgbe: fix issues with failing to detect insert of unsupported module

Several small fixes around negative test case of the insertion of a
IXGBE_ERR_NOT_SUPPORTED module.

- mdio45_probe call was always failing due to mdio.prtad not being
set.  The function set to mdio.mdio_read was still working as we just
happen to always be at prtad == 0.  This will allow us to set the phy_id
and phy.type correctly now.

- There was timing issue with i2c calls when initiated from a tasklet.
A small delay was added to allow the electrical oscillation to calm down.

- Logic change in ixgbe_sfp_task that allows NOT_SUPPORTED condition
to be recognized.

Signed-off-by: Don Skidmore <donald.c.skidmore@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ixgbe/ixgbe_main.c
drivers/net/ixgbe/ixgbe_phy.c