]> bbs.cooldavid.org Git - net-next-2.6.git/commit
V4L/DVB: ivtvfb: prevent reading uninitialized stack memory
authorDan Rosenberg <drosenberg@vsecurity.com>
Wed, 15 Sep 2010 21:44:22 +0000 (18:44 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Tue, 28 Sep 2010 01:22:11 +0000 (22:22 -0300)
commit405707985594169cfd0b1d97d29fcb4b4c6f2ac9
treeb6b33b07cdda4daf60d95783c4892877d4207af2
parentfc00a1d90d7b64e44c2475833cc3021066f67ea7
V4L/DVB: ivtvfb: prevent reading uninitialized stack memory

The FBIOGET_VBLANK device ioctl allows unprivileged users to read 16
bytes of uninitialized stack memory, because the "reserved" member of
the fb_vblank struct declared on the stack is not altered or zeroed
before being copied back to the user.  This patch takes care of it.

Signed-off-by: Dan Rosenberg <dan.j.rosenberg@gmail.com>
Signed-off-by: Andy Walls <awalls@md.metrocast.net>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/video/ivtv/ivtvfb.c