]> bbs.cooldavid.org Git - net-next-2.6.git/commit
tty: avoid recursive BTM in pty_close
authorArnd Bergmann <arnd@arndb.de>
Fri, 18 Jun 2010 12:58:07 +0000 (14:58 +0200)
committerGreg Kroah-Hartman <gregkh@suse.de>
Tue, 10 Aug 2010 20:47:44 +0000 (13:47 -0700)
commit11dbf203922dc70a340417c895c95fb96f6b7068
tree7c79b79c74a184a7d67d3f54af4e37dee930d11e
parenta0821df6e57c8af0053963d0d08c8d5198ea077d
tty: avoid recursive BTM in pty_close

When the console has been redirected, a hangup of the tty
will cause tty_release to be called under the big tty_mutex,
which leads to a deadlock because hangup is also called
under the BTM.

This moves the BTM deeper into the tty_hangup function so
we can close the redirected tty without holding the BTM.
In case of pty, we now need to drop the BTM before
calling tty_vhangup.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Tony Luck <tony.luck@intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: John Kacur <jkacur@redhat.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/char/pty.c
drivers/char/tty_io.c