]> bbs.cooldavid.org Git - net-next-2.6.git/commit
fib: avoid false sharing on fib_table_hash
authorEric Dumazet <eric.dumazet@gmail.com>
Wed, 13 Oct 2010 08:22:03 +0000 (08:22 +0000)
committerDavid S. Miller <davem@davemloft.net>
Sat, 16 Oct 2010 18:13:23 +0000 (11:13 -0700)
commit10da66f7552b3c7966c2f4f1f72009fb0b5539ec
tree517c39912a0aea9d4da3c3915c78e832dfbba855
parent874ffa8f72444d6253d2669fed304875c128f86b
fib: avoid false sharing on fib_table_hash

While doing profile analysis, I found fib_hash_table was sometime in a
cache line shared by a possibly often written kernel structure.

(CONFIG_IP_ROUTE_MULTIPATH || !CONFIG_IPV6_MULTIPLE_TABLES)

It's hard to detect because not easily reproductible.

Make sure we allocate a full cache line to keep this shared in all cpus
caches.

Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/fib_frontend.c
net/ipv6/ip6_fib.c