]> bbs.cooldavid.org Git - net-next-2.6.git/commit
git://bbs.cooldavid.org / net-next-2.6.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 3a4b4aa) | patch
Input: pcf8574_keypad - fix off by one in pcf8574_kp_irq_handler()
authorDan Carpenter <error27@gmail.com>
Sat, 5 Jun 2010 07:34:08 +0000 (00:34 -0700)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Sat, 5 Jun 2010 07:34:45 +0000 (00:34 -0700)
commit0b75f775288b90a83a8708a5af663a03d4bbc9ce
tree1b2ef9436eff1a7ed057ec362f8665f606c23eb7tree | snapshot (tar.bz2 tar.gz zip)
parent3a4b4aaa546fa3d57b2ea7f41234f7d2e328da3fcommit | diff
Input: pcf8574_keypad - fix off by one in pcf8574_kp_irq_handler()

If nextstate == ARRAY_SIZE(lp->btncode), then we read one past the end of
the array on the next line.

This fixes a smatch warning:
drivers/input/misc/pcf8574_keypad.c +74 pcf8574_kp_irq_handler(8)
error: buffer overflow 'lp->btncode' 17 <= 17

Signed-off-by: Dan Carpenter <error27@gmail.com>
Acked-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
drivers/input/misc/pcf8574_keypad.c diff | blob | blame | history
Clone of davem's net-next-2.6 tree