]> bbs.cooldavid.org Git - net-next-2.6.git/commit - net/ipv4/inet_connection_sock.c
inet: Fix virt-manager regression due to bind(0) changes.
authorStephen Hemminger <shemminger@vyatta.com>
Sun, 1 Feb 2009 09:40:17 +0000 (01:40 -0800)
committerDavid S. Miller <davem@davemloft.net>
Sun, 1 Feb 2009 09:40:17 +0000 (01:40 -0800)
commit5add300975cf36b1bd30c461105bb938da260f14
tree4d9bde7687e838a23ba6c1f0b2c3c97322fa6b5d
parentad0f9904444de1309dedd2b9e365cae8af77d9b1
inet: Fix virt-manager regression due to bind(0) changes.

From: Stephen Hemminger <shemminger@vyatta.com>

Fix regression introduced by a9d8f9110d7e953c2f2b521087a4179677843c2a
("inet: Allowing more than 64k connections and heavily optimize
bind(0) time.")

Based upon initial patches and feedback from Evegniy Polyakov and
Eric Dumazet.

From Eric Dumazet:
--------------------
Also there might be a problem at line 175

if (sk->sk_reuse && sk->sk_state != TCP_LISTEN && --attempts >= 0) {
spin_unlock(&head->lock);
goto again;

If we entered inet_csk_get_port() with a non null snum, we can "goto again"
while it was not expected.
--------------------

Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/inet_connection_sock.c