]> bbs.cooldavid.org Git - net-next-2.6.git/commit - net/ipv4/devinet.c
git://bbs.cooldavid.org / net-next-2.6.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 1df2e44) | patch
[IPV4]: Swap the ifa allocation with the"ipv4_devconf_setall" call
authorPavel Emelyanov <xemul@openvz.org>
Sat, 8 Dec 2007 07:55:43 +0000 (23:55 -0800)
committerDavid S. Miller <davem@sunset.davemloft.net>
Tue, 11 Dec 2007 10:45:25 +0000 (02:45 -0800)
commita4e65d36a959005f14142535b58c44cd0f1de8cb
tree8f6e438dfb7e869387538bd4205c01ba05f665f1tree | snapshot (tar.bz2 tar.gz zip)
parent1df2e44560c0d72f381126e52a3ba53614c1c484commit | diff
[IPV4]: Swap the ifa allocation with the"ipv4_devconf_setall" call

According to Herbert, the ipv4_devconf_setall should be called
only when the ifa is added to the device. However, failed
ifa allocation may bring things into inconsistent state.

Move the call to ipv4_devconf_setall after the ifa allocation.

Fits both net-2.6 (with offsets) and net-2.6.25 (cleanly).

Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/devinet.c diff | blob | blame | history
Clone of davem's net-next-2.6 tree