]> bbs.cooldavid.org Git - net-next-2.6.git/commit - net/core/net-sysfs.c
net-sysfs: Use rtnl_trylock in sysfs methods.
authorEric W. Biederman <ebiederm@xmission.com>
Wed, 13 May 2009 16:57:25 +0000 (16:57 +0000)
committerDavid S. Miller <davem@davemloft.net>
Tue, 19 May 2009 05:15:57 +0000 (22:15 -0700)
commit336ca57c3b4e2b58ea3273e6d978ab3dfa387b4c
treee77d80f8e95e0fd15c987c1f1af1d8751800b3af
parent690cc3ffe33ac4a2857583c22d4c6244ae11684d
net-sysfs: Use rtnl_trylock in sysfs methods.

The earlier patch to fix the deadlock between a network device going
away and writing to sysfs attributes was incomplete.
- It did not set signal_pending so we would leak ERSTARTSYS to user space.
- It used ERESTARTSYS which only restarts if sigaction configures it to.
- It did not cover store and show for ifalias.

So fix all of these up and use the new helper restart_syscall so we get
the details correct on what it takes.

Signed-off-by: Eric W. Biederman <ebiederm@aristanetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/net-sysfs.c