]> bbs.cooldavid.org Git - net-next-2.6.git/blobdiff - net/ipv4/icmp.c
net: use the macros defined for the members of flowi
[net-next-2.6.git] / net / ipv4 / icmp.c
index a0d847c7cba5c89aec43b340036bf456468f9e9a..4daebd17b6ede9aa7cb1a50544e978134d986e03 100644 (file)
@@ -379,17 +379,16 @@ static void icmp_reply(struct icmp_bxm *icmp_param, struct sk_buff *skb)
        inet->tos = ip_hdr(skb)->tos;
        daddr = ipc.addr = rt->rt_src;
        ipc.opt = NULL;
-       ipc.shtx.flags = 0;
+       ipc.tx_flags = 0;
        if (icmp_param->replyopts.optlen) {
                ipc.opt = &icmp_param->replyopts;
                if (ipc.opt->srr)
                        daddr = icmp_param->replyopts.faddr;
        }
        {
-               struct flowi fl = { .nl_u = { .ip4_u =
-                                             { .daddr = daddr,
-                                               .saddr = rt->rt_spec_dst,
-                                               .tos = RT_TOS(ip_hdr(skb)->tos) } },
+               struct flowi fl = { .fl4_dst= daddr,
+                                   .fl4_src = rt->rt_spec_dst,
+                                   .fl4_tos = RT_TOS(ip_hdr(skb)->tos),
                                    .proto = IPPROTO_ICMP };
                security_skb_classify_flow(skb, &fl);
                if (ip_route_output_key(net, &rt, &fl))
@@ -506,8 +505,8 @@ void icmp_send(struct sk_buff *skb_in, int type, int code, __be32 info)
                struct net_device *dev = NULL;
 
                rcu_read_lock();
-               if (rt->fl.iif &&
-                       net->ipv4.sysctl_icmp_errors_use_inbound_ifaddr)
+               if (rt_is_input_route(rt) &&
+                   net->ipv4.sysctl_icmp_errors_use_inbound_ifaddr)
                        dev = dev_get_by_index_rcu(net, rt->fl.iif);
 
                if (dev)
@@ -538,26 +537,17 @@ void icmp_send(struct sk_buff *skb_in, int type, int code, __be32 info)
        inet_sk(sk)->tos = tos;
        ipc.addr = iph->saddr;
        ipc.opt = &icmp_param.replyopts;
-       ipc.shtx.flags = 0;
+       ipc.tx_flags = 0;
 
        {
                struct flowi fl = {
-                       .nl_u = {
-                               .ip4_u = {
-                                       .daddr = icmp_param.replyopts.srr ?
-                                               icmp_param.replyopts.faddr :
-                                               iph->saddr,
-                                       .saddr = saddr,
-                                       .tos = RT_TOS(tos)
-                               }
-                       },
+                       .fl4_dst = icmp_param.replyopts.srr ?
+                                  icmp_param.replyopts.faddr : iph->saddr,
+                       .fl4_src = saddr,
+                       .fl4_tos = RT_TOS(tos),
                        .proto = IPPROTO_ICMP,
-                       .uli_u = {
-                               .icmpt = {
-                                       .type = type,
-                                       .code = code
-                               }
-                       }
+                       .fl_icmp_type = type,
+                       .fl_icmp_code = code,
                };
                int err;
                struct rtable *rt2;