From: Marek Szyprowski Date: Sun, 5 Sep 2010 05:42:33 +0000 (-0300) Subject: V4L/DVB: v4l: radio: si470x: fix unneeded free_irq() call X-Git-Tag: v2.6.36-rc8~32^2 X-Git-Url: https://bbs.cooldavid.org/git/?a=commitdiff_plain;h=cc6e853c5e49ea3698e87415672d818c6d7a5ee9;p=net-next-2.6.git V4L/DVB: v4l: radio: si470x: fix unneeded free_irq() call In case of error during probe() the driver calls free_irq() function on not yet allocated irq. This patches fixes the call sequence in case of the error. Signed-off-by: Marek Szyprowski Signed-off-by: Kyungmin Park Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/radio/si470x/radio-si470x-i2c.c b/drivers/media/radio/si470x/radio-si470x-i2c.c index 67a4ec8768a..4ce541a5eb4 100644 --- a/drivers/media/radio/si470x/radio-si470x-i2c.c +++ b/drivers/media/radio/si470x/radio-si470x-i2c.c @@ -395,7 +395,7 @@ static int __devinit si470x_i2c_probe(struct i2c_client *client, radio->registers[POWERCFG] = POWERCFG_ENABLE; if (si470x_set_register(radio, POWERCFG) < 0) { retval = -EIO; - goto err_all; + goto err_video; } msleep(110);