From: Michal Nazarewicz Date: Wed, 5 May 2010 10:53:12 +0000 (+0200) Subject: fs/timerfd.c: make use of wait_event_interruptible_locked_irq() X-Git-Tag: v2.6.35-rc1~471^2~91 X-Git-Url: https://bbs.cooldavid.org/git/?a=commitdiff_plain;h=8120a8aadb2059e29982561658bc6675126f8105;p=net-next-2.6.git fs/timerfd.c: make use of wait_event_interruptible_locked_irq() This patch modifies the fs/timerfd.c to use the newly created wait_event_interruptible_locked_irq() macro. This replaces an open code implementation with a single macro call. Signed-off-by: Michal Nazarewicz Cc: Kyungmin Park Cc: Marek Szyprowski Cc: Alexander Viro Cc: Thomas Gleixner Cc: Roland Dreier Cc: Tejun Heo Cc: Christoph Lameter Cc: Davide Libenzi Signed-off-by: Greg Kroah-Hartman --- diff --git a/fs/timerfd.c b/fs/timerfd.c index 98158de91d2..b86ab8eff79 100644 --- a/fs/timerfd.c +++ b/fs/timerfd.c @@ -110,31 +110,14 @@ static ssize_t timerfd_read(struct file *file, char __user *buf, size_t count, struct timerfd_ctx *ctx = file->private_data; ssize_t res; u64 ticks = 0; - DECLARE_WAITQUEUE(wait, current); if (count < sizeof(ticks)) return -EINVAL; spin_lock_irq(&ctx->wqh.lock); - res = -EAGAIN; - if (!ctx->ticks && !(file->f_flags & O_NONBLOCK)) { - __add_wait_queue(&ctx->wqh, &wait); - for (res = 0;;) { - set_current_state(TASK_INTERRUPTIBLE); - if (ctx->ticks) { - res = 0; - break; - } - if (signal_pending(current)) { - res = -ERESTARTSYS; - break; - } - spin_unlock_irq(&ctx->wqh.lock); - schedule(); - spin_lock_irq(&ctx->wqh.lock); - } - __remove_wait_queue(&ctx->wqh, &wait); - __set_current_state(TASK_RUNNING); - } + if (file->f_flags & O_NONBLOCK) + res = -EAGAIN; + else + res = wait_event_interruptible_locked_irq(ctx->wqh, ctx->ticks); if (ctx->ticks) { ticks = ctx->ticks; if (ctx->expired && ctx->tintv.tv64) {