From: Jerome Glisse Date: Sun, 17 Jan 2010 20:21:41 +0000 (+0100) Subject: drm/radeon/kms: Forbid creation of framebuffer with no valid GEM object X-Git-Tag: v2.6.33-rc6~27^2~6^2~7 X-Git-Url: https://bbs.cooldavid.org/git/?a=commitdiff_plain;h=7e71c9e2e7704ebf044d4a964e02fbd2098a173f;p=net-next-2.6.git drm/radeon/kms: Forbid creation of framebuffer with no valid GEM object This will avoid oops if at later point the fb is use. Trying to create a framebuffer with no valid GEM object is bogus and should be forbidden as this patch does. Signed-off-by: Jerome Glisse Signed-off-by: Dave Airlie --- diff --git a/drivers/gpu/drm/radeon/radeon_display.c b/drivers/gpu/drm/radeon/radeon_display.c index 49f3c69cf24..f899320f0a6 100644 --- a/drivers/gpu/drm/radeon/radeon_display.c +++ b/drivers/gpu/drm/radeon/radeon_display.c @@ -715,7 +715,11 @@ radeon_user_framebuffer_create(struct drm_device *dev, struct drm_gem_object *obj; obj = drm_gem_object_lookup(dev, file_priv, mode_cmd->handle); - + if (obj == NULL) { + dev_err(&dev->pdev->dev, "No GEM object associated to handle 0x%08X, " + "can't create framebuffer\n", mode_cmd->handle); + return NULL; + } return radeon_framebuffer_create(dev, mode_cmd, obj); }