From: Yi Zou <yi.zou@intel.com>
Date: Fri, 9 Apr 2010 21:23:05 +0000 (-0700)
Subject: [SCSI] libfc: bug in erroring out upon FCP_RSP_LEN_VAL in fc_fcp_resp
X-Git-Tag: v2.6.35-rc1~470^2^2~74
X-Git-Url: https://bbs.cooldavid.org/git/?a=commitdiff_plain;h=63ac4bbffb40f2cb3bc7e8b11bac47598813ea13;p=net-next-2.6.git

[SCSI] libfc: bug in erroring out upon FCP_RSP_LEN_VAL in fc_fcp_resp

fc_fcp_resp is assuming when FCP_SNS_LEN_VAL is set, the FCP_RSP_LEN_VAL
is not, which is not true. This leads to not copying the sense data and
error out a valid FCP_RSP.

Signed-off-by: Yi Zou <yi.zou@intel.com>
Signed-off-by: Robert Love <robert.w.love@intel.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
---

diff --git a/drivers/scsi/libfc/fc_fcp.c b/drivers/scsi/libfc/fc_fcp.c
index 220c4bc536c..f99d66fa2ef 100644
--- a/drivers/scsi/libfc/fc_fcp.c
+++ b/drivers/scsi/libfc/fc_fcp.c
@@ -844,8 +844,7 @@ static void fc_fcp_resp(struct fc_fcp_pkt *fsp, struct fc_frame *fp)
 					 * exit here
 					 */
 					return;
-				} else
-					goto err;
+				}
 			}
 			if (flags & FCP_SNS_LEN_VAL) {
 				snsl = ntohl(rp_ex->fr_sns_len);