From: Vasiliy Kulikov <segooon@gmail.com>
Date: Tue, 28 Sep 2010 17:08:08 +0000 (+0400)
Subject: staging: slicoss: use free_netdev(netdev) instead of kfree()
X-Git-Tag: v2.6.37-rc1~60^2~3^2~443
X-Git-Url: https://bbs.cooldavid.org/git/?a=commitdiff_plain;h=20caa14c59dfda3f4be75530e08e439ad2e73580;p=net-next-2.6.git

staging: slicoss: use free_netdev(netdev) instead of kfree()

Freeing netdev without free_netdev() leads to net, tx leaks.
I might lead to dereferencing freed pointer.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

@@
struct net_device* dev;
@@

-kfree(dev)
+free_netdev(dev)

Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
Acked-by: Denis Kirjanov <dkirjanov@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---

diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c
index 58ff1233270..18f11039bb5 100644
--- a/drivers/staging/slicoss/slicoss.c
+++ b/drivers/staging/slicoss/slicoss.c
@@ -3233,7 +3233,7 @@ static void __devexit slic_entry_remove(struct pci_dev *pcidev)
 		slic_global.num_slic_cards--;
 		slic_card_cleanup(card);
 	}
-	kfree(dev);
+	free_netdev(dev);
 	pci_release_regions(pcidev);
 }