]> bbs.cooldavid.org Git - net-next-2.6.git/commitdiff
viafb: deprecate private ioctls
authorFlorian Tobias Schandinat <FlorianSchandinat@gmx.de>
Wed, 10 Mar 2010 23:21:26 +0000 (15:21 -0800)
committerLinus Torvalds <torvalds@linux-foundation.org>
Fri, 12 Mar 2010 23:52:32 +0000 (15:52 -0800)
Print a warning when viafb ioctls are called.  Those should not be used as
their exact meaning is sometimes unknown and they in parts duplicate
functionality present in the framebuffer interface.

There is no known user of these ioctls.

Signed-off-by: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
Cc: Joseph Chan <JosephChan@via.com.tw>
Cc: Scott Fang <ScottFang@viatech.com.cn>
Cc: Krzysztof Helt <krzysztof.h1@poczta.fm>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/video/via/viafbdev.c

index 3028e7ddc3b5a6026ba4d44e75209d3ba690711c..156a900aa884bab44825311d0f8503d322b3e97f 100644 (file)
@@ -476,6 +476,7 @@ static int viafb_ioctl(struct fb_info *info, u_int cmd, u_long arg)
        u32 gpu32;
 
        DEBUG_MSG(KERN_INFO "viafb_ioctl: 0x%X !!\n", cmd);
+       printk(KERN_WARNING "viafb_ioctl: Please avoid this interface as it is unstable and might change or vanish at any time!\n");
        memset(&u, 0, sizeof(u));
 
        switch (cmd) {