]> bbs.cooldavid.org Git - net-next-2.6.git/commitdiff
FRV: Stop gcc from generating uninitialised variable warnings after BUG()
authorDavid Howells <dhowells@redhat.com>
Mon, 27 Apr 2009 10:55:23 +0000 (11:55 +0100)
committerLinus Torvalds <torvalds@linux-foundation.org>
Mon, 27 Apr 2009 15:04:49 +0000 (08:04 -0700)
Stop gcc from generating uninitialised variable warnings after BUG().
The problem is that FRV's call into its gdbstub appears to return (if
the function is marked noreturn, then the compiler is under no
obligation to pass it a return address, and so GDB won't know where the
bug happened).

To get around this, we make the do...while wrapper in _debug_bug_trap()
an endless loop from which there's no escape.

Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
arch/frv/include/asm/bug.h

index 6b1b44d71028f9573d53372e23e5b361ff7ddfa9..2e054508a2f66714376ba0b5c5e880405c15be41 100644 (file)
@@ -30,7 +30,7 @@ extern void __debug_bug_printk(const char *file, unsigned line);
 do {                                           \
        __debug_bug_trap(signr);                \
        asm volatile("nop");                    \
-} while(0)
+} while(1)
 
 #define HAVE_ARCH_BUG
 #define BUG()                                  \
@@ -46,7 +46,8 @@ do {                                          \
 #define HAVE_ARCH_KGDB_BAD_PAGE
 #define kgdb_bad_page(page) do { kgdb_raise(SIGABRT); } while(0)
 #endif
-#endif
+
+#endif /* CONFIG_BUG */
 
 #include <asm-generic/bug.h>