]> bbs.cooldavid.org Git - net-next-2.6.git/commitdiff
[SCSI] qla4xxx: Fix srb lookup in qla4xxx_eh_device_reset
authorKaren Higgins <karen.higgins@qlogic.com>
Wed, 15 Jul 2009 20:03:01 +0000 (15:03 -0500)
committerJames Bottomley <James.Bottomley@HansenPartnership.com>
Thu, 30 Jul 2009 13:50:01 +0000 (08:50 -0500)
eh_device_reset may be called from scsi error handler or sg_reset, etc.
When called from sg_reset, there will not be an associated srb.  The
driver should lookup the corresponding device handle given information
from the supplied cmd structure and should not assume that there exists
an srb.

Signed-off-by: Karen Higgins <karen.higgins@qlogic.com>
Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
drivers/scsi/qla4xxx/ql4_os.c

index e1cc0d21d890981da317ddcae5aacfa9c2d213d4..40e3cafb3a9c54e44e813f738a01eec9c060498a 100644 (file)
@@ -1543,11 +1543,9 @@ static int qla4xxx_eh_device_reset(struct scsi_cmnd *cmd)
 {
        struct scsi_qla_host *ha = to_qla_host(cmd->device->host);
        struct ddb_entry *ddb_entry = cmd->device->hostdata;
-       struct srb *sp;
        int ret = FAILED, stat;
 
-       sp = (struct srb *) cmd->SCp.ptr;
-       if (!sp || !ddb_entry)
+       if (!ddb_entry)
                return ret;
 
        dev_info(&ha->pdev->dev,