]> bbs.cooldavid.org Git - net-next-2.6.git/commitdiff
ring_buffer: fix ring_buffer_event_length()
authorRobert Richter <robert.richter@amd.com>
Wed, 7 Jan 2009 14:32:11 +0000 (15:32 +0100)
committerRobert Richter <robert.richter@amd.com>
Wed, 7 Jan 2009 21:47:40 +0000 (22:47 +0100)
Function ring_buffer_event_length() provides an interface to detect
the length of data stored in an entry. However, the length contains
offsets depending on the internal usage. This makes it unusable. This
patch fixes this and now ring_buffer_event_length() returns the
alligned length that has been used in ring_buffer_lock_reserve().

Cc: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Robert Richter <robert.richter@amd.com>
kernel/trace/ring_buffer.c

index 30d57dd01a857968ef4e3234a8aec1e2bf740e56..d42b882dfe4ba87131beb591aba51179fe4bb209 100644 (file)
@@ -117,7 +117,13 @@ rb_event_length(struct ring_buffer_event *event)
  */
 unsigned ring_buffer_event_length(struct ring_buffer_event *event)
 {
-       return rb_event_length(event);
+       unsigned length = rb_event_length(event);
+       if (event->type != RINGBUF_TYPE_DATA)
+               return length;
+       length -= RB_EVNT_HDR_SIZE;
+       if (length > RB_MAX_SMALL_DATA + sizeof(event->array[0]))
+                length -= sizeof(event->array[0]);
+       return length;
 }
 EXPORT_SYMBOL_GPL(ring_buffer_event_length);