]> bbs.cooldavid.org Git - net-next-2.6.git/commitdiff
mtd: OneNAND: Fix test of unsigned in onenand_otp_walk()
authorRoel Kluin <roel.kluin@gmail.com>
Wed, 16 Dec 2009 00:37:17 +0000 (01:37 +0100)
committerDavid Woodhouse <David.Woodhouse@intel.com>
Wed, 16 Dec 2009 03:26:33 +0000 (03:26 +0000)
mtd->writesize and len are unsigned so the test does not work.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
drivers/mtd/onenand/onenand_base.c

index 3330ea06917cfef04d212932fb3d2ac077c863df..f63b1db3ffb3f0266658a787bc59dd09dd7f2a2a 100644 (file)
@@ -3165,10 +3165,10 @@ static int onenand_otp_walk(struct mtd_info *mtd, loff_t from, size_t len,
 
        /* Check User/Factory boundary */
        if (mode == MTD_OTP_USER) {
-               if (((mtd->writesize * otp_pages) - (from + len)) < 0)
+               if (mtd->writesize * otp_pages < from + len)
                        return 0;
        } else {
-               if (((mtd->writesize * otp_pages) - len) < 0)
+               if (mtd->writesize * otp_pages <  len)
                        return 0;
        }