]> bbs.cooldavid.org Git - net-next-2.6.git/commit
s3c-fb: fix various null references on framebuffer memory alloc failure
authorPawel Osciak <p.osciak@samsung.com>
Wed, 11 Aug 2010 01:02:35 +0000 (18:02 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Wed, 11 Aug 2010 15:59:10 +0000 (08:59 -0700)
commitcd7d7e0244955a4694d1e79e8c8a9bef163d6305
tree2f10b24821d854597dce5d2a351cecb547f68894
parentbc2da1b6fb1a8af9a3226a4f5db3ce32a0a192c9
s3c-fb: fix various null references on framebuffer memory alloc failure

The following problems were found in the above situation:

sfb->windows[win] was being assigned at the end of s3c_fb_probe_win only.
This resulted in passing a NULL to s3c_fb_release_win if probe_win
returned early and a memory leak.

dma_free_writecombine does not allow its third argument to be NULL.

fb_dealloc_cmap does not verify whether its argument is not NULL.

Signed-off-by: Pawel Osciak <p.osciak@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Cc: InKi Dae <inki.dae@samsung.com>
Cc: Ben Dooks <ben-linux@fluff.org>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/video/s3c-fb.c